convert camelCase and snake_case to `BIG_SNAKE_CASE`

[navin772]

User description

Thanks for contributing to Selenium! A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines. Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

A TODO Convert the camelCase and snake_case to BIG_SNAKE_CASE in get_atom_name() function

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• [x] I have read the contributing document.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have added tests to cover my changes.
• [x] All new and existing tests passed.

---

PR Type

enhancement

---

Description

• Enhanced the get_atom_name function to convert camelCase and snake_case to BIG_SNAKE_CASE using regex.
• Added the re module import to support regex operations in the code.

---

Changes walkthrough 📝

	Relevant files
Enhancement	gen_file.py Enhance `get_atom_name` function for case conversion          javascript/private/gen_file.py Added regex to convert camelCase and snake_case to BIG_SNAKE_CASE. Modified the get_atom_name function to handle different case conversions. Imported the re module for regex operations. +5/-2

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[qodo-code-review[bot]]

PR Reviewer Guide 🔍

(Review updated until commit https://github.com/SeleniumHQ/selenium/commit/7603d83a74d3a741bab89af087ac205757b9e575)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Potential Bug The regex pattern for converting camelCase to snake_case might not handle all edge cases correctly, such as consecutive uppercase letters or numbers. Code Smell The function name get_atom_name doesn't accurately reflect its new functionality of converting to BIG_SNAKE_CASE.

[qodo-code-review[bot]]

PR Code Suggestions ✨

Latest suggestions up to 7603d83 Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Add input validation to ensure proper function behavior and prevent potential errors Consider adding input validation to ensure that the 'name' parameter is a non-empty string before processing. javascript/private/gen_file.py [22-27] def get_atom_name(name): + if not isinstance(name, str) or not name: + raise ValueError("Input 'name' must be a non-empty string") # Convert camelCase and snake_case to BIG_SNAKE_CASE name = os.path.basename(name) name = re.sub(r'(?<!^)(?<![_-])(?=[A-Z])', '_', name).lower() name = name.replace('-', '_').upper() return name [ ] Apply this suggestion Suggestion importance[1-10]: 8 Why: Adding input validation is crucial for ensuring the function handles unexpected inputs gracefully, preventing potential runtime errors and improving robustness.	8
Performance	Combine regex operations to enhance performance and readability Consider combining the two regex operations into a single step to improve performance and readability. javascript/private/gen_file.py [25-26] -name = re.sub(r'(?<!^)(?<![_-])(?=[A-Z])', '_', name).lower() -name = name.replace('-', '_').upper() +name = re.sub(r'(?<!^)(?<![_-])(?=[A-Z])|[-]', '_', name).upper() [ ] Apply this suggestion Suggestion importance[1-10]: 7 Why: Combining regex operations into a single step can improve performance and readability by reducing the number of operations, making the code more efficient.	7
Enhancement	Improve variable naming for better code clarity and maintainability Consider using a more descriptive variable name instead of 'name' in the get_atom_name function to improve code readability and maintainability. javascript/private/gen_file.py [22-27] -def get_atom_name(name): +def get_atom_name(input_name): # Convert camelCase and snake_case to BIG_SNAKE_CASE - name = os.path.basename(name) - name = re.sub(r'(?<!^)(?<![_-])(?=[A-Z])', '_', name).lower() - name = name.replace('-', '_').upper() - return name + base_name = os.path.basename(input_name) + snake_case = re.sub(r'(?<!^)(?<![_-])(?=[A-Z])', '_', base_name).lower() + big_snake_case = snake_case.replace('-', '_').upper() + return big_snake_case [ ] Apply this suggestion Suggestion importance[1-10]: 6 Why: The suggestion improves code readability by using more descriptive variable names, which enhances maintainability without altering functionality.	6

💡 Need additional feedback ? start a PR chat

---

Previous suggestions

Suggestions up to commit 3298686

Category	Suggestion	Score
Maintainability	Add explanatory comment for regex pattern Consider adding a comment explaining the regex pattern used for inserting underscores before capital letters to improve code maintainability. javascript/private/gen_file.py [25] +# Insert underscore before capital letters, except at the start of the string name = re.sub(r'(?<!^)(?=[A-Z])', '_', name).lower() Suggestion importance[1-10]: 8 Why: Adding a comment to explain the regex pattern enhances code maintainability by making it easier for future developers to understand the purpose and functionality of the code.	8
	Improve variable naming for better code readability Consider using a more descriptive variable name instead of name in the get_atom_name function to improve code readability and maintainability. javascript/private/gen_file.py [22-27] -def get_atom_name(name): +def get_atom_name(input_name): # Convert camelCase and snake_case to BIG_SNAKE_CASE - name = os.path.basename(name) - name = re.sub(r'(?<!^)(?=[A-Z])', '_', name).lower() - name = name.replace('-', '_').upper() - return name + atom_name = os.path.basename(input_name) + atom_name = re.sub(r'(?<!^)(?=[A-Z])', '_', atom_name).lower() + atom_name = atom_name.replace('-', '_').upper() + return atom_name Suggestion importance[1-10]: 7 Why: The suggestion to use more descriptive variable names improves code readability and maintainability, which is beneficial for understanding and maintaining the code in the long term.	7
Enhancement	Combine string operations for more concise code Consider combining the two string operations (replace and upper) into a single line using method chaining to make the code more concise. javascript/private/gen_file.py [26] +name = name.replace('-', '_').upper() - Suggestion importance[1-10]: 5 Why: Combining string operations into a single line using method chaining makes the code more concise, but the improvement is minor as it does not significantly impact readability or performance.	5

[qodo-code-review[bot]]

Persistent review updated to latest commit https://github.com/SeleniumHQ/selenium/commit/7603d83a74d3a741bab89af087ac205757b9e575

[navin772]

@AutomatedTester can you please review this PR?

[AutomatedTester]

Why are we making this change? This is for generated code that people will never use directly. This code is going to be deleted as we move to bidi

[navin772]

@AutomatedTester, it was a TODO item which I thought of resolving

[diemol]

Thank you for the PR, though, @navin772!