selenium-ide icon indicating copy to clipboard operation
selenium-ide copied to clipboard

fix #1417 - include project name in window title

Open coinzdude opened this issue 2 years ago • 3 comments

Include project title in project editor and initial playback window

coinzdude avatar Apr 22 '23 18:04 coinzdude

fixed with d4f538dc38ccffda6db9d29c7a93360c439930f3

coinzdude avatar Apr 22 '23 18:04 coinzdude

While this appears to work fine, I have a concern on this PR,

packages\selenium-ide\src\main\session\controllers\Playback\index.ts , line 50

I'm not able to use breakpoints at the moment, but my assumption since this used to be === title, that title was "Playback Window" but now I'm not sure about this matching rule here.

coinzdude avatar Apr 22 '23 18:04 coinzdude

@coinzdude - Fair critique, I think the issues here have been addressed 🙂

Let me know if I can help elsewhere here

toddtarsi avatar Apr 24 '23 03:04 toddtarsi

@coinzdude - Closing this PR, as project name is in window title in latest I think

toddtarsi avatar May 08 '24 02:05 toddtarsi