docker-selenium icon indicating copy to clipboard operation
docker-selenium copied to clipboard

[🚀 Feature]: Support for pod labels and annotations for patch-scaledobjects-finalizers job

Open visit1985 opened this issue 1 year ago • 3 comments

Feature and motivation

Please provide a way to specify custom annotations (maybe labels too) in .spec.template.metadata for the patch-scaledobjects-finalizers job introduced in #2222.

Usage example

We have to inject annotations for service mesh compatibility.

visit1985 avatar May 21 '24 13:05 visit1985

@visit1985, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

github-actions[bot] avatar May 21 '24 13:05 github-actions[bot]

Hi @visit1985, for the annotations, you can configure via autoscaling.patchObjectFinalizers.annotations

VietND96 avatar May 21 '24 15:05 VietND96

@VietND96, unfortunately .Values.autoscaling.patchObjectFinalizers.annotations is propagated to the jobs .metadata, not to .spec.template.metadata (which will be propagated to the jobs pod).

visit1985 avatar May 21 '24 16:05 visit1985

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Jul 01 '24 00:07 github-actions[bot]