MLServer icon indicating copy to clipboard operation
MLServer copied to clipboard

Published 20 hours ago • verified publisher icon SeldonIO

add catboost classifier support

Open theofpa opened this issue 3 years ago • 3 comments
trafficstars

add catboost support:

  • add a new runtime by heavily copying lightgbm runtime
  • add test that builds a model, sends an inference request, validates the prediction
  • add example in docs
  • list in index/readme

theofpa avatar Mar 22 '22 12:03 theofpa

Thanks for the review @adriangonz . Since we're adding only the classifier capability I've renamed the contribution and added a TODO for the regressor and ranker capabilities as a future improvement.

theofpa avatar Mar 24 '22 14:03 theofpa

Hey @theofpa, this PR should deal with the click / black issues that broke off the internet today :grimacing:

https://github.com/SeldonIO/MLServer/pull/544

It has been merged already, so if you can rebase, all tests should look better :+1:

adriangonz avatar Mar 29 '22 16:03 adriangonz

Hey @theofpa ,

It seems that the linter is flagging a couple minor changes. The other failing test seems like a non-issue. So if you can update those linter changes, we should be good to go :+1:

adriangonz avatar Apr 08 '22 17:04 adriangonz

Hey @theofpa ,

Conscious it's been a while since this PR was opened, so we'll close the PR for now. However, if you get a chance to have a look in the near future, it would be great to pick it up again!

adriangonz avatar Aug 31 '22 08:08 adriangonz