MLServer icon indicating copy to clipboard operation
MLServer copied to clipboard

Published 20 hours ago • verified publisher icon SeldonIO

Fix kafka json byte encoding to match rest server

Open DerTiedemann opened this issue 1 year ago • 6 comments
trafficstars

fixes #1621

DerTiedemann avatar Mar 05 '24 00:03 DerTiedemann

@DerTiedemann many thanks for you draft PR. This looks fine in general. We are happy to potentially accept your contribution once it is ready and reviewed.

sakoush avatar Mar 11 '24 20:03 sakoush

@sakoush ready for review!

DerTiedemann avatar Mar 13 '24 13:03 DerTiedemann

@DerTiedemann any feedback on review comments?

sakoush avatar Apr 19 '24 15:04 sakoush

I haven't been able to work on this recently. In general they are fine and I agree with the requested changes.

DerTiedemann avatar Apr 25 '24 15:04 DerTiedemann

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 22 '24 17:05 CLAassistant

@DerTiedemann I have re-triggered CI actions. Looks like there are some issues, e.g linting. For now please discard macos tests as they are currently broken anyway.

sakoush avatar May 29 '24 20:05 sakoush

@DerTiedemann many thanks for the contribution. I rebased, fixed minor linting issues and merged it.

sakoush avatar Jul 04 '24 13:07 sakoush