MLServer icon indicating copy to clipboard operation
MLServer copied to clipboard

Add Japanese language dependencies

Open jbauer2718 opened this issue 1 year ago • 9 comments
trafficstars

Resolves #1506

jbauer2718 avatar Dec 12 '23 19:12 jbauer2718

@sakoush I believe I have addressed your comments. Let me know if I have misunderstood something!

jbauer2718 avatar Dec 14 '23 00:12 jbauer2718

@sakoush Hey! Hope your holidays went well. Just bumping this to your attention because I think it's ready if not close to ready to merge. Let me know if I misunderstood some of your comments. Looking forward to your feedback.

jbauer2718 avatar Jan 11 '24 06:01 jbauer2718

Hey @sakoush , the pipeline is failing on TF v2.14 dropping support for Python 3.8. Would you rather drop support for Python 3.8 for this runtime or have me deprecate TF to v2.13?

jbauer2718 avatar Jan 17 '24 19:01 jbauer2718

@sakoush Looked into this a bit more. I am pretty sure we're going to have to bump to 3.9 unless we deprecate tensorflow-io too. In my personal opinion, I think it just makes sense to go this route rather than freeze all of our tensorflow dependencies forever. Let me know what you think.

jbauer2718 avatar Jan 17 '24 20:01 jbauer2718

@jbauer2718 could you please rebase your changes on top of latest master as there are now merge conflicts.

sakoush avatar Mar 11 '24 22:03 sakoush

@sakoush I synced with the main branch. Looks like some packages were updated in the runtime lockfiles. Let me know if you want me to explicitly revert these, but should be GTG.

jbauer2718 avatar Apr 12 '24 15:04 jbauer2718

@jbauer2718 it looks like that merge conflicts have not been resolved correctly, at least by looking at the changes in docs/examples/huggingface/README.md

sakoush avatar Apr 16 '24 14:04 sakoush

@sakoush Sorry for missing that. Should be good now.

jbauer2718 avatar Apr 16 '24 17:04 jbauer2718

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 22 '24 17:05 CLAassistant