Sukera

Results 194 comments of Sukera

My usecase is consistency of `show` with what users can type/have access to; in the REPL this is `Main`, in other places it would of course be that module. I...

I've adjusted the code to first try to retrieve a given context module from the given `IO`, falling back to `active_module()`. I think this is the best option here.

Failures are real - seems like I missed some earlier! I'll get to them tomorrow.

Does this need anything else (cc @KristofferC)?

`UnionAll`s and `Union`s are not equal, even if their effective extent may be, no? This is the same case, and I wouldn't necessarily expect them to be equal, since one...

The underlying issue, if there is one, is that `skipmissing` just iterates a `Dict`, which gives us pairs of `key => value`. `argmax` then maximizes that pair and since the...

Yes, that's more or less what I suggested in the last paragraph, giving a (hopefully helpful) error message instead. That may result in people complaining though, since it is a...

> It may be better to deprecate instead of throwing an error. Yes, a deprecation may be in order. > I also don't see how it would solve the issue...

In this particular case, yes. Again, there is an inherent ambiguity due to how `skipmissing`, the iteration interface and `Dict` play with each other - after all, you can have...

That's why `pairs` exists, yes (and I think ultimately where the language is headed), but we nonetheless can't change the current behavior in any 1.x.