mjml-net icon indicating copy to clipboard operation
mjml-net copied to clipboard

Published 20 hours ago • verified publisher icon SebastianStehle

<td> attribute is valign not vertical-align

Open skybber opened this issue 2 years ago • 5 comments

At the following line atribute vertical-align= instead of valign= is appended to

attributes: https://github.com/SebastianStehle/mjml-net/blob/f834b2b4e4f99fd61ce5f32a34e0e86676680962/Mjml.Net/Components/Body/ColumnComponent.cs#L215

skybber avatar Apr 13 '23 06:04 skybber

Where do you see it here?

https://github.com/mjmlio/mjml/blob/master/packages/mjml-column/src/index.js#L298

SebastianStehle avatar Apr 13 '23 18:04 SebastianStehle

I think that's wrong even in JS implementation:

https://github.com/mjmlio/mjml/blob/master/packages/mjml-column/src/index.js#L261

skybber avatar Apr 14 '23 06:04 skybber

Probably. But then tests might fail...

SebastianStehle avatar Apr 15 '23 14:04 SebastianStehle

Will be fixed as soon as the mjml bug is fixed: https://github.com/mjmlio/mjml/issues/2684

SebastianStehle avatar May 25 '23 12:05 SebastianStehle

Should already be fixed.

SebastianStehle avatar Jan 12 '24 17:01 SebastianStehle