sea-query icon indicating copy to clipboard operation
sea-query copied to clipboard

Remove separate WithQuery to ensure it can be specified everywhere

Open bouk opened this issue 1 year ago • 2 comments

Instead, move the with clause into insert/update/select/delete. This makes sure you can specify with WITH clause to any method that takes a SelectStatement/UpdateStatement/InsertStatement/DeleteStatement.

PR Info

  • Closes #813

Breaking Changes

  • [x] This removes WithQuery and changes the signature of .with()

bouk avatar Sep 06 '24 10:09 bouk

Thank you for your contribution. While I appreciate now that we can use a with clause in all statement types, removing WithQuery is breaking. Is there a middleground where we still keep it?

tyt2y3 avatar Oct 01 '24 23:10 tyt2y3

We could keep both kinds and deprecate WithQuery, removing it in a later version.

bouk avatar Oct 08 '24 16:10 bouk

@tyt2y3 @bouk see #859 which implements the suggested approach

rumpuslabs avatar Jan 24 '25 07:01 rumpuslabs

Closed in favour of https://github.com/SeaQL/sea-query/pull/859

tyt2y3 avatar Feb 16 '25 17:02 tyt2y3