scuffle icon indicating copy to clipboard operation
scuffle copied to clipboard

try fix hevc transcoding

Open TroyKomodo opened this issue 3 months ago • 5 comments

fixes #509

TroyKomodo avatar Aug 26 '25 21:08 TroyKomodo

Deploying scuffle-docrs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c61fde5
Status: ✅  Deploy successful!
Preview URL: https://9b08becb.scuffle-docrs.pages.dev
Branch Preview URL: https://pr-524.scuffle-docrs.pages.dev

View logs

Codecov Report

:x: Patch coverage is 33.33333% with 50 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 71.10%. Comparing base (0ae71fd) to head (9101536). :warning: Report is 610 commits behind head on main.

Files with missing lines Patch % Lines
crates/mp4/src/boxes/types/hvc1.rs 29.57% 50 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   71.24%   71.10%   -0.15%     
==========================================
  Files         322      323       +1     
  Lines       26490    26562      +72     
==========================================
+ Hits        18874    18886      +12     
- Misses       7616     7676      +60     
Files with missing lines Coverage Δ
crates/mp4/src/boxes/types/ftyp.rs 95.00% <100.00%> (-1.62%) :arrow_down:
crates/transmuxer/src/codecs/hevc.rs 97.61% <100.00%> (ø)
crates/transmuxer/src/lib.rs 94.27% <100.00%> (ø)
crates/transmuxer/src/tests/mod.rs 99.45% <100.00%> (ø)
crates/mp4/src/boxes/types/hvc1.rs 29.57% <29.57%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
scuffle-aac 89.47% <ø> (ø)
scuffle-amf0 89.74% <ø> (ø)
scuffle-av1 98.40% <ø> (ø)
scuffle-batching 100.00% <ø> (ø)
scuffle-bootstrap 84.16% <ø> (ø)
scuffle-bytes-util 94.63% <ø> (ø)
scuffle-context 100.00% <ø> (ø)
scuffle-expgolomb 100.00% <ø> (ø)
scuffle-ffmpeg 90.00% <ø> (ø)
scuffle-flv 95.59% <ø> (ø)
scuffle-future-ext 33.33% <ø> (ø)
nutype-enum ∅ <ø> (∅)
scuffle-h264 99.36% <ø> (ø)
scuffle-http 85.94% <ø> (ø)
scuffle-metrics 95.02% <ø> (ø)
postcompile 44.24% <ø> (ø)
scuffle-pprof 100.00% <ø> (ø)
scuffle-rtmp 90.88% <ø> (ø)
scuffle-settings 99.11% <ø> (ø)
scuffle-signal 95.41% <ø> (ø)
:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 26 '25 21:08 codecov[bot]

Is there a valid use case for hev1 in general? I'm wondering if we should still support it or if this change intends to only support hvc1.

philipch07 avatar Aug 26 '25 22:08 philipch07

It seems with flv the codec type is always hvc1 which is why i changed it here. I am not sure exactly maybe @joetIO

TroyKomodo avatar Aug 26 '25 22:08 TroyKomodo

Deployment of docs-scuffle-rs

https://docs-scuffle-opik1lb76-scufflecloud.vercel.app

github-actions[bot] avatar Aug 27 '25 17:08 github-actions[bot]