prompt-injection icon indicating copy to clipboard operation
prompt-injection copied to clipboard

Integration tests for router.ts

Open heatherlogan-scottlogic opened this issue 2 years ago • 2 comments

Feature Request

Description

Add integration tests to cover the router.ts file.

Additional context

This will be done by sending requests to the endpoints in the router file, and checking the responses.

Acceptance criteria

This ticket should just add new tests, so can skip the testing step.

heatherlogan-scottlogic avatar Oct 18 '23 13:10 heatherlogan-scottlogic

Adding a question label as the router file is just endpoints now. Likely just need to change this to 'add integration tests for controller modules'.

gsproston-scottlogic avatar Dec 13 '23 09:12 gsproston-scottlogic

Adding a question label as the router file is just endpoints now. Likely just need to change this to 'add integration tests for controller modules'.

Clarified on refinement that integration test should be testing how the code integrates with other external systems (not other internal modules). So here we can still do integration tests for router.ts, by hitting the endpoints with requests and checking the responses. It would still be nice to have unit tests for the controller files that don't have them, however.

gsproston-scottlogic avatar Dec 14 '23 15:12 gsproston-scottlogic