Scott Santucci

Results 125 comments of Scott Santucci
trafficstars

Figured it out. `which-key--update` sets `which-key--automatic-display`: https://github.com/justbur/emacs-which-key/blob/db3d003e903deb07394b4e572206f809578278c6/which-key.el#L2680 `which-key--show-page` always calls set transient map: https://github.com/justbur/emacs-which-key/blob/db3d003e903deb07394b4e572206f809578278c6/which-key.el#L2202-L2205 But `which-key--get-popup-map` returns nil if `which-key--automatic-display` is set: https://github.com/justbur/emacs-which-key/blob/db3d003e903deb07394b4e572206f809578278c6/which-key.el#L2095-L2103 **This can be fixed by** moving the...

Could this be because [_mocha#L467](/mochajs/mocha/blob/master/bin/_mocha#L467) isn't wrapped in `process.on('exit',` like [_mocha#L461](/mochajs/mocha/blob/master/bin/_mocha#L461) is (both passed to `run` at [_mocha#L458](/mochajs/mocha/blob/master/bin/_mocha#L458) based on a condition that I can't figure out what would set...

In principle I'm generally for being able to differentiate pending tests from tests that are skipped due to hook failures. (Something breaking in the test itself, on the other hand,...

I have branches that do this with Karma that I need to rebase (and see if the issues on Sauce went away or not). Bonus: the test coverage for the...

This behavior is correct/consistent: `before` only runs once per suite (and the retries functionality only reruns individual tests and not whole suites). Is there a particular problem you are trying...

Hi @dalimian, sorry about the wait -- I haven't had a whole lot of time to think this one over. I can tell you that that's a fairly unusual case...

> don't really like referencing props with underscores - `_currentRetry` but other than that pretty clean no? Indeed! I've chewed this over and I can think of a few approaches:...

Hmm, the option to retry all failing tests in a `describe` in one go, with `before` and `after`, is very interesting. I'll have to think about whether that covers all...

I'm not sure this is actually fixable; in general, it's pretty hard (even moreso the wider the range of environments supported) to programmatically determine which function started a given piece...

Fair enough! (The bot went a little overkill on old issues as we're updating some labels and it filters based on labels. Sorry about that.) It occurs to me that...