Main icon indicating copy to clipboard operation
Main copied to clipboard

[Bug]: Px persist directive creates a 'px.ini' folder instead of a file

Open nicerloop opened this issue 1 year ago • 0 comments

Prerequisites

  • [X] I have written a descriptive issue title.
  • [X] I have searched all issues/PRs to ensure it has not already been reported or fixed.
  • [X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

Px

Expected/Current Behaviour

Upon clean install of main/px, an empty px.ini folder is created in persist/px instead of a px.ini file. In fact the px.ini file does not initially exist inside the application folder, resulting in the folder being created instead of the (absent) file being moved.

Steps to Reproduce

PS C:\Users\xxxxxx> scoop install main/px
Installing 'px' (0.9.2) [64bit] from main bucket
Loading px-v0.9.2-windows-amd64.zip from cache
Checking hash of px-v0.9.2-windows-amd64.zip ... ok.
Extracting px-v0.9.2-windows-amd64.zip ... done.
Linking ~\scoop\apps\px\current => ~\scoop\apps\px\0.9.2
Creating shim for 'px'.
Persisting px.ini
'px' (0.9.2) was installed successfully!
PS C:\Users\xxxxxx> ls .\scoop\persist\px\

    Directory: C:\Users\xxxxxx\scoop\persist\px

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----          14/03/2024    14:53                px.ini

PS C:\Users\xxxxxx>

Possible Solution

The px.ini file should be created by 'px --save' launched inside the application folder during pre_install. The px.ini location should also be configured globally with an env_set block for PX_CONFIG variable.

Alternatively, the persist block could be removed to keep the install closer to vanilla.

Scoop and Buckets Version

PS C:\Users\xxxxxx> scoop --version
Current Scoop version:
v0.3.1 - Released at 2022-11-15

'extras' bucket:
18640e828 (HEAD -> master, origin/master, origin/HEAD) wavebox: Update to version 10.122.35.2

'java' bucket:
4b5a5f6b (HEAD -> master, origin/master, origin/HEAD) dragonwell17-jdk: Update to version 17.0.10.0.11-17.0.10

'main' bucket:
de5a1537f (HEAD -> master, origin/master, origin/HEAD) unbound: Update to version 1.19.3

'sysinternals' bucket:
e669cc0 (HEAD -> main, origin/main, origin/HEAD) chore(ci): switch to `pull_request_target` trigger

PS C:\Users\xxxxxx>

Scoop Config

PS C:\Users\xxxxxx> scoop config

last_update         proxy          scoop_branch scoop_repo
-----------         -----          ------------ ----------
14/03/2024 14:04:08 localhost:3128 master       https://github.com/ScoopInstaller/Scoop

PS C:\Users\xxxxxx>

PowerShell Version

PS C:\Users\xxxxxx> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.4.1
PSEdition                      Core
GitCommitId                    7.4.1
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

PS C:\Users\xxxxxx>

Additional Softwares

No response

nicerloop avatar Mar 14 '24 14:03 nicerloop