Extras icon indicating copy to clipboard operation
Extras copied to clipboard

geforce-now: Add nightly

Open bepoli opened this issue 5 years ago • 8 comments

Nightly, it autoupdates itself. User's config is stored in %localappdata%/NVIDIA Corporation, so it's not 100% portable.

bepoli avatar Oct 31 '20 14:10 bepoli

/verify

Ash258 avatar Nov 03 '20 18:11 Ash258

All changes look good.

Wait for review from human collaborators.

geforce-now

  • [x] Description
  • [x] License

github-actions[bot] avatar Nov 03 '20 18:11 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 27 '21 18:10 stale[bot]

Version number may be found in https://www.nvidia.com/en-us/geforce-now/release-highlights/

niheaven avatar Dec 02 '21 06:12 niheaven

"checkver": {
    "url": "https://www.nvidia.com/en-us/geforce-now/release-highlights/",
    "regex": "GeForce NOW ([\\d.]+)"
}

niheaven avatar Dec 02 '21 07:12 niheaven

Version number may be found in https://www.nvidia.com/en-us/geforce-now/release-highlights/

@niheaven Thanks for the info. I thought about that one, but the "build version" is not on the page. This will lead to frequent hash check errors in the future.

I am planning to use our new UpdateTracker to download "first 8 bytes" to check if the file was changed, and track the full version number by downloading the file.

geforce-now2

geforce-now

issaclin32 avatar Dec 02 '21 09:12 issaclin32

Is it a rare case that increase build version within same minor version? If it is, then manually redownload and hash the package may be simpler.

niheaven avatar Dec 02 '21 10:12 niheaven

I recommend closing this pull request if autoupdate feature is impossible to be done. The nature of this app is also not a perfect fit for the Extras bucket to be included.

Per https://github.com/vedantmgoyal2009/vedantmgoyal2009/blob/main/winget-pkgs-automation/packages/n/nvidia.geforcenow.json it is possible to find the newest version for autoupdate. winget has had this package for months now. I do agree that this is a better fit for the games bucket though.

superusercode avatar May 02 '23 21:05 superusercode