Extras icon indicating copy to clipboard operation
Extras copied to clipboard

[Bug]: msiafterburner won't install

Open vipaware opened this issue 1 year ago • 4 comments

Prerequisites

  • [X] I have written a descriptive issue title.
  • [X] I have searched all issues/PRs to ensure it has not already been reported or fixed.
  • [X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

msiafterburner

Expected/Current Behaviour

msiafterburner won't install. Instead, a few errors popup, ending up in failed install.

Steps to Reproduce

PS> scoop install extras/msiafterburner
Installing 'msiafterburner' (4.6.5) [64bit] from 'extras' bucket
MSIAfterburnerSetup.zip (55,6 MB) [===================================================================================================] 100%
Checking hash of MSIAfterburnerSetup.zip ... ok.
Extracting MSIAfterburnerSetup.zip ... done.
Running pre_install script...Remove-Item : Cannot find path 'C:\Users\me\scoop\apps\msiafterburner\4.6.5\Redist' because it does not exist.
At line:2 char:1
+ Remove-Item "$dir\`$*", "$dir\Uninstall*", "$dir\Redist" -Recurse
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\Users\me\sc...er\4.6.5\Redist:String) [Remove-Item], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

done.
Linking ~\scoop\apps\msiafterburner\current => ~\scoop\apps\msiafterburner\4.6.5
Creating shim for 'MSIAfterburner'.
Get-Command : The term 'MSIAfterburner.exe' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the sp
elling of the name, or if a path was included, verify that the path is correct and try again.
At C:\Users\me\scoop\apps\scoop\current\lib\install.ps1:757 char:21
+             $bin = (Get-Command $target).Source
+                     ~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (MSIAfterburner.exe:String) [Get-Command], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException,Microsoft.PowerShell.Commands.GetCommandCommand

Can't shim 'MSIAfterburner.exe': File doesn't exist.
PS>

Possible Solution

Not sure, something's wrong with the pre_install script?

Scoop and Buckets Version

PS> scoop --version
Current Scoop version:
716b6db3 (HEAD -> master, tag: v0.5.0, origin/master, origin/HEAD) chore(release): Bump to version 0.5.0 (#6035)

'main' bucket:
603e1d7c9 (HEAD -> master, origin/master, origin/HEAD) uv: Update to version 0.2.22

'extras' bucket:
9a0557220 (HEAD -> master, origin/master, origin/HEAD) vtm: Update to version 0.9.86

Scoop Config

PS> scoop config

last_update                       scoop_repo                              scoop_branch
-----------                       ----------                              ------------
2024-07-08T01:13:44.4164278+03:00 https://github.com/ScoopInstaller/Scoop master

PowerShell Version

PS C:\Users\ViP> $PSVersionTable
                                                                                                                                                 Name                           Value
----                           -----
PSVersion                      5.1.22621.3672
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22621.3672
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Additional Softwares

Not much, just recently did a clean win11 install, didn't have time yet to put back my apps.

vipaware avatar Jul 07 '24 22:07 vipaware

Could somebody look into this? Still can't install MSI Afterburner.

vipaware avatar Jul 13 '24 19:07 vipaware

The preinstall script tries to extract the contents of the installer EXE, but 7Zip fails to read the contents of the EXE:

image

Maybe Afterburner has changed their installer EXE format?

jamesWalker55 avatar Sep 18 '24 09:09 jamesWalker55

Likely due to the new bundled Norton antivirus in the installer:

image

jamesWalker55 avatar Sep 18 '24 09:09 jamesWalker55

I checked the installer with the "Norton 360 for Gamer" option, and it downloads a zipped archive into a temporary directory. For me, it was:

C:\Users\user\AppData\Local\Temp\MSI_Afterburner_Installer\File\77B8B2E9-593F-45F3-A32E-778730B62B6B\MSIAfterburnerSetup.zip

Inside this archive, there's a file called MSIAfterburnerSetup465.exe, which is the correct setup file for installing MSI Afterburner.

The advertisement installer also creates a log file in the same directory where it was executed. The log file contains the following error:

[ERROR] File executable not found! (C:\Users\user\AppData\Local\Temp\MSI_Afterburner_Installer\File\77B8B2E9-593F-45F3-A32E-778730B62B6B\MSIAfterburnerSetup\MSIAfterburnerSetup465.exe)

It seems that the installer failed to unpack the archive, which caused the setup to fail on my system.

codekillerxx avatar Oct 22 '24 13:10 codekillerxx