No longer subclass `DateConverter` in `NetCDFTimeConverter`

[spencerkclark]

🚀 Pull Request

This is a proof of concept to show that we can no longer subclass mpl.dates.DateConverter in NetCDFTimeConverter without any ill effects. I think it is unlikely that anyone downstream is depending on this relatively low-level detail of nc-time-axis, so it feels reasonably safe to change without a deprecation cycle, but I would be open to opinions of folks who feel otherwise.

xref: https://github.com/matplotlib/matplotlib/issues/24951, https://github.com/matplotlib/matplotlib/pull/25662

cc: @ksunden

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4320c72) 93.10% compared to head (5e7fd71) 93.10%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files           1        1           
  Lines         203      203           
  Branches       47       47           
=======================================
  Hits          189      189           
  Misses          7        7           
  Partials        7        7           

Impacted Files	Coverage Δ
nc_time_axis/__init__.py	93.10% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[bjlittle]

@spencerkclark This is great, thanks for raising this.

Perhaps we should wait for the dust to settle on mpl and then see if this flies?

[spencerkclark]

@bjlittle agreed! In the short term I was posting this to signal to @ksunden that the design matplotlib settles on in https://github.com/matplotlib/matplotlib/pull/25662 does not necessarily need to hinge too strongly on this detail of nc-time-axis.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}