iris icon indicating copy to clipboard operation
iris copied to clipboard

Use the new re-entrant do-nothing script

Open trexfeathers opened this issue 1 year ago • 3 comments

🚀 Pull Request

Description

Just a draft so we can trial it in the upcoming release.

https://github.com/SciTools-incubator/nothing

  • [x] need to set appropriate permissions for the new repo

Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • https://github.com/SciTools/iris/labels/benchmark_this

trexfeathers avatar Jul 18 '24 16:07 trexfeathers

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.83%. Comparing base (7bca716) to head (33f2cd7). Report is 59 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6062   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files          88       88           
  Lines       23315    23315           
  Branches     4338     4338           
=======================================
  Hits        20945    20945           
  Misses       1644     1644           
  Partials      726      726           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 18 '24 17:07 codecov[bot]

Tested this in use + it was handy But it would be nice if the "nothing" package allowed you to restart from latest stored. I created a couple of issues to suggest improvements in the common code package : https://github.com/SciTools-incubator/nothing/issues/1 https://github.com/SciTools-incubator/nothing/issues/2

pp-mo avatar Sep 12 '24 11:09 pp-mo

Tested this in use + it was handy But it would be nice if the "nothing" package allowed you to restart from latest stored. I created a couple of issues to suggest improvements in the common code package : SciTools-incubator/nothing#1 SciTools-incubator/nothing#2

Thanks @pp-mo these are great suggestions! I don't consider them a blocker to this PR, which I know @HGWright is looking at today.

trexfeathers avatar Sep 12 '24 13:09 trexfeathers

Thanks @ESadek-MO!

trexfeathers avatar Nov 04 '24 10:11 trexfeathers