cartopy icon indicating copy to clipboard operation
cartopy copied to clipboard

Improve matrixing in GHA to work with SciTools/cartopy#2303

Open trexfeathers opened this issue 1 year ago • 1 comments

Rationale

When a test fails, image results are uploaded. Since actions/upload-artifact@v4 (#2303), it is the responsibility of the workflow YAML file to avoid name clashes in the artifacts. This PR makes sure that the whole matrix is included in the artifact name and path, avoiding clashes between matrix.shapely-dev true vs false.

Implications

Failures for ubuntu-latest, latest python will not result in one of the image uploads failing due to a name clash with the other.

trexfeathers avatar Jan 11 '24 15:01 trexfeathers

Proof of concept - successful image uploads both here and here.

trexfeathers avatar Jan 11 '24 15:01 trexfeathers

Thanks, people!

trexfeathers avatar Mar 11 '24 09:03 trexfeathers