statsample icon indicating copy to clipboard operation
statsample copied to clipboard

Removing linear regression support in Statsample

Open lokeshh opened this issue 9 years ago • 5 comments

I think its reasonable to remove linear regression support in Statsample because of following reasons:

  • Its equivalent which is Normal regression lies in Statsample-GLM
  • This way all regression models would lie in Statsample-GLM
  • Statsample-GLM already supports predicting on new data which Statsample doesn't yet
  • Normal regression in Statsample-GLM works without an intercept providing more flexibility
  • This will keep regression models management limited to Statsample-GLM and Statsample gem would be responsible for other statistic tools other than regression, hence simplifying the management.

lokeshh avatar Jul 21 '16 17:07 lokeshh

Works. Go ahead.

v0dro avatar Jul 21 '16 17:07 v0dro

@v0dro Ok. Well, then it also implies https://github.com/SciRuby/statsample/pull/51 would be no longer needed. Right?

lokeshh avatar Jul 21 '16 17:07 lokeshh

Are there any particular cases in statsample that are not covered in statsample-glm? If no, then you can safely remove linear regression from statsample and not re-implement the formula language in this gem too (I think that's what you're doing given the commits in #51 - I've been out on vacation so could not follow up on daily activities).

v0dro avatar Jul 21 '16 18:07 v0dro

Yes you are right. I was implementing formula language in #51. I'm removing it now and will now add a PR to remove multiple regression.

lokeshh avatar Jul 22 '16 17:07 lokeshh

Statsample is much faster than Statsample-GLM as these benchmark shows.

lokeshh avatar Aug 07 '16 04:08 lokeshh