nmatrix icon indicating copy to clipboard operation
nmatrix copied to clipboard

Update rspec dependency

Open v0dro opened this issue 9 years ago • 9 comments

Why is RSpec still at 2.14 in nmatrix? Any specific reason?

I think we should update it to 3.4 (latest).

v0dro avatar Dec 16 '15 07:12 v0dro

Well, we get a ton of warnings about using deprecated RSpec features that will behave differently in RSpec 3. So we would need to change a bunch of tests.

wlevine avatar Dec 16 '15 16:12 wlevine

Is that it?

I think I can do the needful whenever I get some free time.

v0dro avatar Dec 16 '15 17:12 v0dro

@v0dro Are you on it? If you are not working on this issue let me know. I am interested in doing this.

lokeshh avatar Dec 21 '15 12:12 lokeshh

Well I'll take some time (~2 weeks). If you're going to do this right away then feel free to do so :)

v0dro avatar Dec 21 '15 12:12 v0dro

Ok you do it. I will find something else to work upon.

lokeshh avatar Dec 21 '15 14:12 lokeshh

Is there some reason we need the additional features in 3.4? It isn't always beneficial to change a gem dependency. There should be a motivation behind such a change.

translunar avatar Dec 21 '15 14:12 translunar

It shows a whole load of deprecation warnings regarding change of syntax.

v0dro avatar Dec 21 '15 17:12 v0dro

Related to #294

v0dro avatar Jan 14 '16 06:01 v0dro

Looks like rspec-longrun now supports rspec 3.x, so we can go ahead with upgrading to a newer rspec. :)

https://github.com/mdub/rspec-longrun/issues/5#issuecomment-132267353

translunar avatar Jun 20 '18 14:06 translunar