daru-view icon indicating copy to clipboard operation
daru-view copied to clipboard

Update JS files for the libraries

Open Shekharrajak opened this issue 8 years ago • 8 comments

Developers can update the js files using these command in the repo:

rake library_name:update

e.g. rake highcharts:update

To update all the JS files : rake update_all

But how user will update it (who have installed the gem from the source or using gem install) ?

Probably we can have CLI and using command daur-view update_js library_name user can update the particular js . I like the way Thor gem works. But there is some other good Command Line Interface Gems as well.

Shekharrajak avatar Aug 02 '17 05:08 Shekharrajak

I think we should use ARGV because the gem is less likely to get CLI intensive in future. WDYT?

rohitner avatar Mar 04 '18 18:03 rohitner

ping! @Shekharrajak I would like to take up this issue

rohitner avatar Mar 07 '18 17:03 rohitner

@rohitner , sorry for late response! Yes , we didn't think much about CLI in daru-view. But to update the js files, calling method don't look a good choice to me. I am not sure about it. Can you light more on your idea?

@zverok , what do you think?

Shekharrajak avatar Mar 08 '18 06:03 Shekharrajak

@rohitner , meanwhile you can open PR with your idea.

Shekharrajak avatar Mar 08 '18 13:03 Shekharrajak

We can also make use of optparse module like that being done by the gem colorls (although Thor has advantages like seperate parsers for different commands). I think OptionParse class will be most appropriate at this point.

rohitner avatar Mar 08 '18 13:03 rohitner

@rohitner

I think we should use ARGV because the gem is less likely to get CLI intensive in future.

I am not sure what do you mean, can you please elaborate?

zverok avatar Mar 08 '18 20:03 zverok

I mean to say that using pre-installed modules like optparse are enough for supporting a few command line arguments rather than adding third-party dependencies like Thor.

rohitner avatar Mar 09 '18 10:03 rohitner

Pending work after PR #83

https://github.com/SciRuby/daru-view/pull/83#issuecomment-394606927

Shekharrajak avatar Jun 05 '18 14:06 Shekharrajak