SciMLSensitivity.jl
SciMLSensitivity.jl copied to clipboard
Use the SciMLStructures Tunable interface
This uses the SciMLStructures Tunable interface https://github.com/SciML/SciMLStructures.jl in order to allow more generalized definitions of p.
- [ ] Ensure Lux.jl is well supported (componentarrays extension in SciMLStructures
- [ ] Add a test for a custom SciMLStructure
You need to actually pass repack?
https://github.com/SciML/SciMLSensitivity.jl/blob/dcf961ad5739be4167877a25bc6ec6fb36198cb7/src/concrete_solve.jl#L219
Yeah this isn't quite done. We should do a branch of, if it's a mutable structure then we just use replace!(::AbstractPortion, p::T1, new_values), and only repack if it's immutable.
Something isn't completely clicking with me, how this change can be so simple.
Where is the logic living that when in the adjoint equations df/dp and dg/dp occurs, we should only take the tunable parameters?
I should've marked WIP. Plan to finish it during today.
Can we expect this to be released by Monday?
yes