SciMLSensitivity.jl icon indicating copy to clipboard operation
SciMLSensitivity.jl copied to clipboard

Use the SciMLStructures Tunable interface

Open ChrisRackauckas opened this issue 1 year ago • 5 comments
trafficstars

This uses the SciMLStructures Tunable interface https://github.com/SciML/SciMLStructures.jl in order to allow more generalized definitions of p.

  • [ ] Ensure Lux.jl is well supported (componentarrays extension in SciMLStructures
  • [ ] Add a test for a custom SciMLStructure

ChrisRackauckas avatar Feb 08 '24 10:02 ChrisRackauckas

You need to actually pass repack? https://github.com/SciML/SciMLSensitivity.jl/blob/dcf961ad5739be4167877a25bc6ec6fb36198cb7/src/concrete_solve.jl#L219

ArnoStrouwen avatar Feb 08 '24 10:02 ArnoStrouwen

Yeah this isn't quite done. We should do a branch of, if it's a mutable structure then we just use replace!(::AbstractPortion, p::T1, new_values), and only repack if it's immutable.

ChrisRackauckas avatar Feb 08 '24 10:02 ChrisRackauckas

Something isn't completely clicking with me, how this change can be so simple. Where is the logic living that when in the adjoint equations df/dp and dg/dp occurs, we should only take the tunable parameters?

ArnoStrouwen avatar Feb 08 '24 11:02 ArnoStrouwen

I should've marked WIP. Plan to finish it during today.

ChrisRackauckas avatar Feb 09 '24 09:02 ChrisRackauckas

Can we expect this to be released by Monday?

xtalax avatar Feb 09 '24 14:02 xtalax

yes

ChrisRackauckas avatar Jun 28 '24 01:06 ChrisRackauckas