MethodOfLines.jl icon indicating copy to clipboard operation
MethodOfLines.jl copied to clipboard

Interpolating if one or more of the dimensions has length 1.

Open Qfl3x opened this issue 2 years ago • 2 comments

#304

Still has a warning assertion in case all ivs have length 1. Otherwise it will build an interpolation object for the non-"singleton" ivs.

If the model is prompted to give the solution using the interpolator, it will silently ignore the missing ivs and only consider the ivs for which length is > 1.

Performance shouldn't be too big of an issue, though it would've been better to only do the singleton ivs lookup once.

It's all silent, so feel free to add warnings or let me know if you want warnings.

Qfl3x avatar Oct 12 '23 14:10 Qfl3x

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (6c8b78d) 69.95% compared to head (9af715e) 85.81%. Report is 13 commits behind head on master.

Files Patch % Lines
src/interface/solution/common.jl 20.00% 8 Missing :warning:
src/interface/solution/solution_utils.jl 80.00% 1 Missing :warning:
src/system_parsing/pde_system_transformation.jl 50.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #330       +/-   ##
===========================================
+ Coverage   69.95%   85.81%   +15.85%     
===========================================
  Files          38       40        +2     
  Lines        1741     1769       +28     
===========================================
+ Hits         1218     1518      +300     
+ Misses        523      251      -272     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 12 '23 15:10 codecov[bot]

Hey, rebase and this should pass - thanks!

xtalax avatar Nov 14 '23 22:11 xtalax