MethodOfLines.jl icon indicating copy to clipboard operation
MethodOfLines.jl copied to clipboard

`@to_kw` macro for easy boundary conditions

Open anandijain opened this issue 3 years ago • 6 comments

I write the code, you write the docs :P

feel free to unexport or change stuff

anandijain avatar Dec 07 '22 10:12 anandijain

Codecov Report

Merging #215 (ef56f35) into master (450fc88) will increase coverage by 1.85%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   74.93%   76.79%   +1.85%     
==========================================
  Files          37       37              
  Lines        1851     1870      +19     
==========================================
+ Hits         1387     1436      +49     
+ Misses        464      434      -30     
Impacted Files Coverage Δ
src/MOL_utils.jl 67.93% <100.00%> (+6.11%) :arrow_up:
src/interface/solution/common.jl 19.69% <0.00%> (-22.73%) :arrow_down:
src/MOL_discretization.jl 64.70% <0.00%> (-10.93%) :arrow_down:
...ion/schemes/upwind_difference/upwind_difference.jl 84.05% <0.00%> (-4.35%) :arrow_down:
src/system_parsing/pde_system_transformation.jl 39.28% <0.00%> (+0.59%) :arrow_up:
src/discretization/differential_discretizer.jl 97.43% <0.00%> (+2.56%) :arrow_up:
src/system_parsing/bcs/parse_boundaries.jl 87.78% <0.00%> (+6.10%) :arrow_up:
src/discretization/discretize_vars.jl 86.66% <0.00%> (+6.66%) :arrow_up:
...tization/schemes/half_offset_centred_difference.jl 100.00% <0.00%> (+13.15%) :arrow_up:
... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Dec 07 '22 10:12 codecov[bot]

Deal, try get this to pass first though :)

xtalax avatar Dec 07 '22 17:12 xtalax

Seems good now

anandijain avatar Dec 09 '22 13:12 anandijain

Looks good, can you move out to_kw to its own file though? MOL_utils.jl is a monster in bad need of splitting up, and I want to keep it internally focused.

xtalax avatar Dec 09 '22 17:12 xtalax

I allowed edits by maintainers, mind doing that so it looks right to you?

anandijain avatar Dec 09 '22 17:12 anandijain

Sure, I'll get to this. Thanks for your contribution :)

xtalax avatar Dec 09 '22 19:12 xtalax