memilio icon indicating copy to clipboard operation
memilio copied to clipboard

Refactor ABM code: Rename EPI to MIO and mobility to movement

Open xsaschako opened this issue 1 year ago • 1 comments

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

  • changed PI to MIO and mobility to movement

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • [x] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • [x] New code adheres to coding guidelines
  • [x] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • [x] Tests are added for new functionality and a local test run was successful
  • [x] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • [x] Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • [x] (For ABM development) Checked benchmark results

Checks by code reviewer(s)

  • [ ] Corresponding issue(s) is/are linked and addressed
  • [ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • [ ] Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
  • [ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

xsaschako avatar Dec 21 '23 14:12 xsaschako

Codecov Report

Attention: Patch coverage is 92.27273% with 17 lines in your changes missing coverage. Please review.

Project coverage is 96.12%. Comparing base (a97183a) to head (cb5b3ea). Report is 1 commits behind head on main.

Files Patch % Lines
cpp/models/abm/model.cpp 76.59% 11 Missing :warning:
...memilio/mobility/metapopulation_mobility_instant.h 95.91% 2 Missing :warning:
...ilio/mobility/metapopulation_mobility_stochastic.h 86.66% 2 Missing :warning:
cpp/models/abm/model.h 85.71% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
- Coverage   96.14%   96.12%   -0.02%     
==========================================
  Files         131      131              
  Lines       11047    11049       +2     
==========================================
  Hits        10621    10621              
- Misses        426      428       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 21 '23 15:12 codecov[bot]