memilio icon indicating copy to clipboard operation
memilio copied to clipboard

Naming of function get_dt() in integrator.h

Open jubicker opened this issue 2 years ago • 1 comments

Motivation / Current Behaviour

The function get_dt() in integrator.h returns m_next_dt instead of m_dt.

Enhancement description

A better naming of the function would be get_next_dt().

Additional context

No response

Checklist

  • [X] Attached labels, especially loc:: or model:: labels.
  • [X] Linked to project

jubicker avatar Jun 28 '23 13:06 jubicker

The issue description is obsolete, OdeIntegrator no longer holds a dt. It was moved to Simulation in #574, if I'm not mistaken.

Could you check whether the current naming/documentation of Simulation::get_dt is sufficient? Please update or close this issue accordingly.

reneSchm avatar Sep 18 '24 09:09 reneSchm