memilio
memilio copied to clipboard
506 build static and shared libraries
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively. As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
- [ ] There is at least one issue associated with the pull request.
- [ ] The branch follows the naming conventions as defined in the git workflow.
- [ ] New code adheres with the coding guidelines
- [ ] Make sure that the pre-commit linting/style checks pass.
If functions were changed or functionality was added:
- [ ] Tests for new functionality has been added
- [ ] A local test was succesful
If new functionality was added:
- [ ] There is appropriate documentation of your work. (use doxygen style comments)
If new third party software is used:
- [ ] Did you pay attention to its license? Please remember to add it to the wiki after successful merging.
If new mathematical methods or epidemiological terms are used:
- [ ] Are new methods referenced? Did you provide further documentation? Has the glossary been updated?
The following questions are addressed in the documentation if need be:
-
[ ] Developers (what did you do?, how can it be maintained?)
-
[ ] For users (how to use your work?)
-
[ ] For admins (how to install and configure your work?)
-
For documentation: Please write or update the Readme in the current working directory!
Checks by code reviewer(s):
- [ ] Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
- [ ] The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
- [ ] There are appropriate unit tests and they pass.
- [ ] The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
- [ ] Coverage report for new code is acceptable.
closes #506 closes #647
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e2e5dc7) 95.40% compared to head (f88c493) 92.06%.
:exclamation: Current head f88c493 differs from pull request most recent head 54fa887. Consider uploading reports for the commit 54fa887 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 95.40% 92.06% -3.35%
==========================================
Files 117 91 -26
Lines 9231 7084 -2147
==========================================
- Hits 8807 6522 -2285
- Misses 424 562 +138
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.