memilio icon indicating copy to clipboard operation
memilio copied to clipboard

135 contact reduction npi local

Open DavidKerkmann opened this issue 3 years ago • 4 comments

Changes

Implements tool to compute NPI reduction for any given county. What can be improved:

  • Age resolved data for each county. For now, 'cases_all_county_age.json' is used because it contains the required age resolution.
  • Read-in of NPI is not implemented. For now, the NPI can be hard-coded in the file. Once we have some fixed NPI object structure and a way to export them in some way, this can be implemented.

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively. As many checkboxes as possible should be ticked.

Checks by code author:

  • [x] There is at least one issue associated with the pull request.
  • [x] The branch follows the naming conventions as defined in the git workflow.
  • [x] New code adheres with the coding guidelines
  • [ ] Tests for new functionality has been added
  • [x] A local test was succesful
  • [x] There is appropriate documentation of your work. (use doxygen style comments)
  • [ ] If new third party software is used, did you pay attention to its license? Please remember to add it to the wiki after successful merging.
  • [ ] If new mathematical methods or epidemiological terms are used, has the glossary been updated ? Did you provide further documentation ? is present or referenced. Please provide your references.
  • [ ] The following questions are addressed in the documentation*: Developers (what did you do?, how can it be maintained?), For users (how to use your work?), For admins (how to install and configure your work?)
  • For documentation: Please write or update the Readme in the current working directory!

Checks by code reviewer(s):

  • [ ] Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • [ ] The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • [ ] There are appropriate unit tests and they pass.
  • [ ] The git history is clean and linearized for the merge request.
  • [ ] Coverage report for new code is acceptable.

closes #135

DavidKerkmann avatar May 12 '22 08:05 DavidKerkmann

I changed the title to 135 as this is related to issue #135 (and not issue #257)

mknaranja avatar Oct 04 '22 07:10 mknaranja

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.98%. Comparing base (aaacb23) to head (2aba838). Report is 134 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files         112      112           
  Lines        8776     8776           
=======================================
  Hits         8336     8336           
  Misses        440      440           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 12 '23 08:10 codecov[bot]

My comments dated from long ago, I forgot to submit them. I think the script is still useful and important to compute estimated total contact reduction. I am not sure though if it is correct. We would need to look at it again. In the future, one could think of integrating a similar output directly to C++.

mknaranja avatar Oct 12 '23 09:10 mknaranja

@HenrZu We should discuss how to continue and output contact reduction for ODE model summary statistics

mknaranja avatar Feb 07 '24 09:02 mknaranja

@HenrZu I think an output on this information is important. Maybe even better to directly do this in cpp. I close this here. Could you address this in https://github.com/SciCompMod/memilio/issues/135?

mknaranja avatar Oct 16 '24 20:10 mknaranja