memilio
memilio copied to clipboard
468 Abm parameter study
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
- Simplify ParameterStudy, so it can use any parameter type and more generic simulations.
- This strongly changes the class layout and usage.
- Add example for an ABM study.
- Usage and behavior in python bindings is mostly unchanged.
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
- [x] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
- [x] New code adheres to coding guidelines
- [x] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
- [x] Tests are added for new functionality and a local test run was successful (with and without OpenMP)
- [x] Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
- [ ] Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
- [x] Proper attention to licenses, especially no new third-party software with conflicting license has been added
- [ ] (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.
Checks by code reviewer(s)
- [ ] Corresponding issue(s) is/are linked and addressed
- [ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
- [ ] Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
- [ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
- [ ] On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).
Codecov Report
:x: Patch coverage is 94.36620% with 4 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 97.25%. Comparing base (aa541c0) to head (0c1e723).
:warning: Report is 7 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| cpp/memilio/compartments/parameter_studies.h | 92.72% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1395 +/- ##
========================================
Coverage 97.25% 97.25%
========================================
Files 176 182 +6
Lines 15466 15662 +196
========================================
+ Hits 15041 15232 +191
- Misses 425 430 +5
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.