memilio icon indicating copy to clipboard operation
memilio copied to clipboard

Published 20 hours ago • verified publisher icon SciCompMod

Holiday data is outdated

Open kilianvolmer opened this issue 6 months ago • 2 comments

Bug description

The german school holidays are only added in the code until 2024.

Version

Any

To reproduce

Take a look at https://github.com/ICB-DCM/orga/discussions/categories/q-a

Relevant log output

Add any relevant information, e.g. used compiler, screenshots.

Checklist

  • [x] Attached labels, especially loc:: or model:: labels.
  • [ ] Linked to project

kilianvolmer avatar May 12 '25 09:05 kilianvolmer

@dabele Do you still have the code for this?

mknaranja avatar May 22 '25 09:05 mknaranja

I couldn't find it. It wasn't a lot of code, the API seems to still be working. One thing to watch out for is the weekends. If I remember correctly, weekends are always part of the holidays in the data, which could lead to inconsistencies. But I'm not sure if/how we handled that.

dabele avatar May 22 '25 11:05 dabele