memilio icon indicating copy to clipboard operation
memilio copied to clipboard

1019 Adjust memilio-generation for flow models and automatic differentiation

Open dr2001dlr opened this issue 1 year ago • 1 comments

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

-Scanner now checks for Flowmodel and Compartmentalmodel -pymio includes fixed in template_string -config.json does not need age_group, simulation and parameterset_wrapper annymore (scanner is setting those) -added simulate and simulate_flows -added interpolate_simulation_result and interpolate_ensemble_results -added scalartype in intermediate_representation to set a datatype for bindings

If need be, add additional information and what the reviewer should look out for in particular:

-Check if the bindings are correct

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • [ ] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • [ ] New code adheres to coding guidelines
  • [ ] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • [ ] Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • [ ] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • [ ] Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • [ ] (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • [ ] Corresponding issue(s) is/are linked and addressed
  • [ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • [ ] Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • [ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • [ ] On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1019

dr2001dlr avatar Dec 02 '24 13:12 dr2001dlr

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.21%. Comparing base (12b041d) to head (e69207a). Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
- Coverage   97.23%   97.21%   -0.02%     
==========================================
  Files         155      156       +1     
  Lines       14278    14674     +396     
==========================================
+ Hits        13883    14266     +383     
- Misses        395      408      +13     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 02 '24 13:12 codecov[bot]