memilio icon indicating copy to clipboard operation
memilio copied to clipboard

1117 reduce use of get support max method in ide model to reduce run time

Open annawendler opened this issue 1 year ago • 1 comments

Changes and Information

  • Store support_max for all TransitionDistributions in a vector
  • Compute derivative and cotribution of survival functions to force of infection terms once at the beginning of the simulation and store them instead of recomputing these in every time step to decrease run time

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • [x] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • [x] New code adheres to coding guidelines
  • [x] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • [ ] Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • [x] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • [x] Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • [ ] (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • [ ] Corresponding issue(s) is/are linked and addressed
  • [ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • [ ] Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • [ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • [ ] On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1117

annawendler avatar Sep 26 '24 12:09 annawendler

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.59%. Comparing base (a1028b5) to head (b245a36). Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
+ Coverage   96.44%   96.59%   +0.14%     
==========================================
  Files         135      137       +2     
  Lines       11285    11057     -228     
==========================================
- Hits        10884    10680     -204     
+ Misses        401      377      -24     
Flag Coverage Δ
96.59% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 26 '24 12:09 codecov[bot]