memilio icon indicating copy to clipboard operation
memilio copied to clipboard

1081 rework abm state transitions

Open jubicker opened this issue 1 year ago • 1 comments

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • [ ] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • [ ] New code adheres to coding guidelines
  • [ ] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • [ ] Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • [ ] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • [ ] Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • [ ] (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • [ ] Corresponding issue(s) is/are linked and addressed
  • [ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • [ ] Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • [ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • [ ] On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

coses #1081

jubicker avatar Aug 13 '24 09:08 jubicker

Codecov Report

Attention: Patch coverage is 96.97842% with 21 lines in your changes missing coverage. Please review.

Project coverage is 97.21%. Comparing base (004a774) to head (d499cfa). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
cpp/memilio/utils/parameter_distributions.h 95.08% 12 Missing :warning:
...pp/memilio/utils/abstract_parameter_distribution.h 91.66% 6 Missing :warning:
cpp/memilio/utils/logging.h 0.00% 3 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1107    +/-   ##
========================================
  Coverage   97.21%   97.21%            
========================================
  Files         154      156     +2     
  Lines       14193    14670   +477     
========================================
+ Hits        13798    14262   +464     
- Misses        395      408    +13     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 22 '24 11:08 codecov[bot]

My suggestion is to close #811 and #664 while #1081 and #688 include the symptomatic state inclusion/seperation, which is not covered here.

DavidKerkmann avatar Jan 10 '25 09:01 DavidKerkmann

Benchmark results

Main:

---------------------------------------------------------------------------
Benchmark                                 Time             CPU   Iterations
---------------------------------------------------------------------------
abm_benchmark/abm_benchmark_50k        3674 ms         3674 ms            1
abm_benchmark/abm_benchmark_100k       7194 ms         7194 ms            1
abm_benchmark/abm_benchmark_200k      15479 ms        15479 ms            1

Branch:

---------------------------------------------------------------------------
Benchmark                                 Time             CPU   Iterations
---------------------------------------------------------------------------
abm_benchmark/abm_benchmark_50k        4225 ms         4225 ms            1
abm_benchmark/abm_benchmark_100k       8582 ms         8582 ms            1
abm_benchmark/abm_benchmark_200k      18787 ms        18786 ms            1

jubicker avatar Mar 26 '25 12:03 jubicker