palettegram icon indicating copy to clipboard operation
palettegram copied to clipboard

fix: Landing page along with navbar made responsive at md screen

Open SnehansuBehera opened this issue 1 year ago • 17 comments
trafficstars

Related Issue

Fixes #311

Description

The alignment and spacing of the landing page, navbar, footer i.e, every page of the website made responsive for the screen widths exceeding 768px of screen.

Screenshots

Screenshot 2024-05-18 132630 Screenshot 2024-05-18 132654

Summary by CodeRabbit

  • Style
    • Updated footer and navbar components with improved padding for better layout on different screen sizes.
    • Enhanced text alignment and sizes on the home page for a more consistent and readable appearance.

SnehansuBehera avatar May 18 '24 07:05 SnehansuBehera

@SnehansuBehera is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 18 '24 07:05 vercel[bot]

Walkthrough

The recent updates primarily focus on enhancing the layout and styling of the Footer, Navbar, and Home components. These changes include adding padding for different screen sizes, refining class names for better readability, and adjusting text sizes and alignments to improve the overall user interface and user experience.

Changes

File Path Change Summary
src/components/core/footer/index.tsx Updated className to include md:px-10 for padding adjustments on medium screens.
src/components/core/navbar/index.tsx Enhanced styling classes for navigation and menu toggle buttons, adding padding and refining class names.
src/components/pages/home/index.tsx Adjusted padding values in the main element and modified text sizes and alignments for better readability.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 18 '24 07:05 coderabbitai[bot]

@yashd-dev please review the pr

SnehansuBehera avatar May 18 '24 08:05 SnehansuBehera

Hi @SnehansuBehera,

As per mentioned in the issue here, you have to fix the alignment of all the pages to get it merged. There are many pages into the application that are not optimized for tablets size

Sanchitbajaj02 avatar May 18 '24 08:05 Sanchitbajaj02

I got you @Sanchitbajaj02 you can close this pr as of now, I am working on other pages too and then I will create a new pr.

SnehansuBehera avatar May 18 '24 09:05 SnehansuBehera

I got you @Sanchitbajaj02 you can close this pr as of now, I am working on other pages too and then I will create a new pr.

You can also work and merge it with this

Sanchitbajaj02 avatar May 18 '24 11:05 Sanchitbajaj02

@Sanchitbajaj02 could you suggest what should i do, unless i get registered i could not go to the "Get Started" section. Screenshot 2024-05-18 195351

SnehansuBehera avatar May 18 '24 14:05 SnehansuBehera

@Sanchitbajaj02 could you suggest what should i do, unless i get registered i could not go to the "Get Started" section. Screenshot 2024-05-18 195351

Can you tell me the steps to replicate? also is it occured on local or on production?

Sanchitbajaj02 avatar May 19 '24 16:05 Sanchitbajaj02

I tried to register by filling the name, email, password. It occurred locally @Sanchitbajaj02

SnehansuBehera avatar May 19 '24 16:05 SnehansuBehera

I tried to register by filling the name, email, password. It occurred locally @Sanchitbajaj02

Are you able to login?

Sanchitbajaj02 avatar May 22 '24 04:05 Sanchitbajaj02

I tried to register by filling the name, email, password. It occurred locally @Sanchitbajaj02

Are you able to login?

No

SnehansuBehera avatar May 22 '24 05:05 SnehansuBehera

I tried to register by filling the name, email, password. It occurred locally @Sanchitbajaj02

Are you able to login?

No

I have updated the readme and provided the account. You can check that out

Sanchitbajaj02 avatar May 22 '24 05:05 Sanchitbajaj02

I tried to register by filling the name, email, password. It occurred locally @Sanchitbajaj02

Are you able to login?

No

I have updated the readme and provided the account. You can check that out

Screenshot 2024-05-22 114847

SnehansuBehera avatar May 22 '24 06:05 SnehansuBehera

Can you open it in some different browser?

Sanchitbajaj02 avatar May 22 '24 06:05 Sanchitbajaj02

I tried to register by filling the name, email, password. It occurred locally @Sanchitbajaj02

Are you able to login?

No

I have updated the readme and provided the account. You can check that out

Screenshot 2024-05-22 114847

Are you using it locally or on production?

Sanchitbajaj02 avatar May 23 '24 05:05 Sanchitbajaj02

Locally.

SnehansuBehera avatar May 23 '24 06:05 SnehansuBehera

Locally.

The email and password I created is for production. How can I configure a password for your local instance. Refer #300. This will help you in fixing your server issue locally

Sanchitbajaj02 avatar May 23 '24 13:05 Sanchitbajaj02

@SnehansuBehera any progress on this issue?

Sanchitbajaj02 avatar May 24 '24 15:05 Sanchitbajaj02

@SnehansuBehera any progress on this issue?

still unable to login in production also

SnehansuBehera avatar May 24 '24 15:05 SnehansuBehera

@SnehansuBehera any progress on this issue?

still unable to login in production also

Have you tried in incognito or some other browser? because I have asked and tested this issue but everyone are easy to logged into application. If issue is still there, ping me on discord

Sanchitbajaj02 avatar May 24 '24 18:05 Sanchitbajaj02

@Sanchitbajaj02 please add the labels like gssoc and level1 for both issue and pr

SnehansuBehera avatar May 29 '24 19:05 SnehansuBehera

@Sanchitbajaj02 please add the labels like gssoc and level1 for both issue and pr

gssoc is added that will grant you 1 point but level1 I can't add since the code that I fetched only do changes on

  • footer
  • navbar
  • home page

As clearly mentioned many times. You have to check for the responsive on all the routes i.e on

  • /user/:is
  • /feed
  • /boomarks
  • /register
  • /login
  • /verify
  • reset-password

Since, this PR is partially enabling the functionality it promises, I am marking only gssoc tag

Sanchitbajaj02 avatar May 29 '24 19:05 Sanchitbajaj02