palettegram
palettegram copied to clipboard
fix: Navbar section updated for mobile view
Related Issue
fixes: #305
Description
Improved/enhanced the navbar section for the mobile view
Screenshots
Before change
After change
Added theme button so that user can easily shift from dark to light mode or vice-versa
Summary by CodeRabbit
Summary by CodeRabbit
- Improvements
- Enhanced the layout and styling of the Navbar for a better visual presentation and user experience on both desktop and mobile views.
- Minor formatting adjustments to the Theme Button for code consistency.
Someone is attempting to deploy a commit to the Sanchit Bajaj's projects Team on Vercel.
A member of the Team first needs to authorize it.
Walkthrough
The recent changes aim to enhance the layout and styling of the Navbar component to improve visual presentation and user experience on both desktop and mobile views. Specific adjustments were made to elements like the hamburger menu button, theme button, login/register links, and the mobile menu. Additionally, a minor formatting change was implemented in the themeButton component.
Changes
| Files | Change Summary |
|---|---|
src/components/core/navbar/index.tsx |
Adjusted the layout and styling of the Navbar component, including the hamburger menu button, theme button, login/register links, and mobile menu for better UX. |
src/components/core/themeButton/index.tsx |
Minor modification involving a change in whitespace at the end of the file. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
| Navbar toggler not working on mobile device (#305) | ✅ | |
| Theme button should be on the right-most corner (#305) | ✅ |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger a review. This is useful when automatic reviews are disabled for the repository.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
@AbhiDiva96 why this is raised and not included into your previous PR?
I don't want to mess up all the things on that PR. I will close that PR. When you review this one. Please go with this PR @Sanchitbajaj02
Hey @Sanchitbajaj02 Pls review this PR
Hey @Sanchitbajaj02 Pls review this PR
PR is pulled locally and in review process. It will be merged today
thank-you so much @Sanchitbajaj02
@Sanchitbajaj02 please consider this PR as the final one. on forward I am not going to make any other PR. I have pushed all the changes in this one. so sorry for bothering you.
@Sanchitbajaj02 please consider this PR as the final one. on forward I am not going to make any other PR. I have pushed all the changes in this one. so sorry for bothering you.
I added reviews in this pr as well as in your old PRs. Please do that to get it merged. If you're facing problems related to raising prs and git please reach out to me on discord
@AbhiDiva96 Please acknowledge the changes that I have raised. If you have any doubt, please respond. I will close this PR in 48hrs if you didn't
I closed the initial two PR. This is the final PR please review and merge it this PR waiting for reviews pls merge it. @Sanchitbajaj02
I closed the initial two PR. This is the final PR please review and merge it this PR waiting for reviews pls merge it. @Sanchitbajaj02
Hi @AbhiDiva96 i have told many times above that you have to change some things to get it merged. Please fix those things then I will merge. It is not just that you create something and I merge it blindly
dear @Sanchitbajaj02 i have added all your requirements. which you gave to me in the above. i have add a commit name "improve ui of navbar in mobile view". if any query ping me
image of commit
dear @Sanchitbajaj02 i have added all your requirements. which you gave to me in the above. i have add a commit name "improve ui of navbar in mobile view". if any query ping me
image of commit
take latest update from master since it has some merge conflicts. Fix them and I will merge
