CredSweeper icon indicating copy to clipboard operation
CredSweeper copied to clipboard

Export results transformation (subtext and hashed)

Open babenek opened this issue 1 year ago • 1 comments

Description

Please include a summary of the change and which is fixed.

  • Add --subtex to shrink long lines in report and prevent extra memory usage
  • Add --hashed to hide sesible information in report

TODO: --strip for line to support benchmark markup

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • [x] UnitTest
  • [x] Benchmark after https://github.com/Samsung/CredSweeper/pull/580

babenek avatar Jul 14 '24 05:07 babenek

Codecov Report

Attention: Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.12%. Comparing base (31dcd1d) to head (31e74e2). Report is 1 commits behind head on main.

Files Patch % Lines
credsweeper/credentials/line_data.py 73.33% 3 Missing and 1 partial :warning:
credsweeper/credentials/candidate.py 75.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
- Coverage   90.15%   90.12%   -0.04%     
==========================================
  Files         129      131       +2     
  Lines        4642     4708      +66     
  Branches      752      759       +7     
==========================================
+ Hits         4185     4243      +58     
- Misses        304      310       +6     
- Partials      153      155       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 14 '24 05:07 codecov-commenter

Implementation is rather tangled. The solution for a quite rare task is not worth the overcomplication of this part of the code.

--subtext reduces json report size of unfiltered data for ML train. --hashes allows use report of sensetive data for BM without data disclosure

babenek avatar Aug 14 '24 08:08 babenek