pymsis icon indicating copy to clipboard operation
pymsis copied to clipboard

feat: refresh F10.7 and ap data handling with partial data support

Open mananapr opened this issue 10 months ago • 3 comments

Refresh F10.7 and ap data handling with partial data support and automatic updates

Closes #69

mananapr avatar Jan 06 '25 10:01 mananapr

Hi @greglucas, I've pushed another commit based on your suggestions.

  • I have removed the partial download functionality because like you said, it is a lot of headache
  • I am getting the last observation date from the warnings data like you mentioned.
  • I am still keeping the check on file update date to prevent pymsis from re-downloading the SW file each time the program runs in case the end date is not present in the csv file

Let me know what you think.

mananapr avatar Jan 23 '25 09:01 mananapr

@mananapr I pushed a commit up to your branch to try and fix up some of the failing tests. Unfortunately, it was more involved than I hoped, so there is a bit more work there than anticipated. It also apparently didn't fix the issue :-/ But it does work locally for me. Feel free to drop that commit if you don't like it and continue on in a different way to try and get the tests to pass too.

greglucas avatar Jan 28 '25 05:01 greglucas

@mananapr I pushed a commit up to your branch to try and fix up some of the failing tests. Unfortunately, it was more involved than I hoped, so there is a bit more work there than anticipated. It also apparently didn't fix the issue :-/ But it does work locally for me. Feel free to drop that commit if you don't like it and continue on in a different way to try and get the tests to pass too.

Ah, I totally missed that. Will look into the changes, thanks!

mananapr avatar Feb 03 '25 08:02 mananapr