sui
sui copied to clipboard
SUI-Components
feat(packages/sui-react-web-vitals): rollback to log targets with empty values again
Description
The empty values are a bug of the library, in principle, we eliminate them for not sending them to Open Search, and eliminate noise, but not having the target empties gives us a distortion of the real percentages of the attributions, and that is why we resubmit them.
how's that? TBH I didn't really get why wouldn't we log those empty values...
The empty values are a bug of the library, in principle, we eliminate them for not sending them to Open Search, and eliminate noise, but not having the target empties gives us a distortion of the real percentages of the attributions, and that is why we resubmit them.
I just added the explanation as a description in the the PR 😜
how's that? TBH I didn't really get why wouldn't we log those empty values...
The empty values are a bug of the library, in principle, we eliminate them for not sending them to Open Search, and eliminate noise, but not having the target empties gives us a distortion of the real percentages of the attributions, and that is why we resubmit them.
I just added the explanation as a description in the the PR 😜
that's what I thought in the first place... if we were to remove empty values, there'd be an overrepresentation of the elements that get their attribution and name correctly
