Zhiqiang ZHOU
Zhiqiang ZHOU
I have - removed the testcase condiitons for rootles containers - squashed into 1 commit PTAL @AkihiroSuda :heart:
> BuildKit v0.11 will support `buildctl du --format json`, so maybe we will reopen #1284 after its GA So you mean we still prefer to parse the JSON output rather...
just mention the discussion result: we prefer to break the API instead of introducing a new type called `ErrorWithWarnings`, ref: https://github.com/kubernetes-sigs/controller-runtime/issues/1896#issuecomment-1327672092
Hi! I have updated this PR with these changes: - stop using `goerrors "errors"` in import - move `error` as the last value returned by methods, eg. `ValidateCreate() ( err...
> Hi! I have updated this PR with these changes: > > * stop using `goerrors "errors"` in import > * move `error` as the last value returned by methods,...
> @STRRL do you have time to address the findings above? yeah! I would follow up!
/retest resolved the conflicts
ptal @sbueringer :heart:
Updated! PTAL @sbueringer :heart: