Steve Ramage

Results 47 comments of Steve Ramage

Just in case it's not clear, here is an example, I can speed up autocompletion, by doing this in my main method: ``` if os.Args[1] == "__complete" { DisableExpensiveCommandFields =...

Hey @dhui I came across this thread, and was thinking about this a bit more. You mentioned not creating a DDL here and I certainly understand that. I also looked...

> Was your plan to keep calling Next() until you hit an error? Or were you planning on added a Last() method to source.Driver? I think it was to call...

> +1. If we do this, let's go with successive calls to Next() to avoid any interfaces changes. The performance hit should be negligible in most cases. Sounds good >...

I played around with this, and I think I may have something that works, it is much simpler if I can read the migrations more than once. I will send...

> How over-provisioned are your clusters? If the rolling deploy size is smaller than the over-provisioned amount, then there shouldn't be any issues unless there's an unexpected traffic spike see_no_evil...

I created a proof of concept, where I hacked together enough to get the CLI to work here: https://github.com/liquibase/liquibase-mongodb/pull/31 If you follow the [README.md](https://github.com/liquibase/liquibase-mongodb/pull/31/files#diff-04c6e90faac2675aa89e2176d2eec7d8R113) instructions it will guide you through...

I think changing this line: https://github.com/liquibase/liquibase-mongodb/blob/e1e4bfa3865f7125c1c54e748990d88129b83fbd/src/main/java/liquibase/ext/mongodb/lockservice/MongoLockService.java#L97 To: } catch (DatabaseException | MongoException e) { Will fix it (although maybe I broke it).

I also observed that multiple threads can seemingly get the lock, looking at the code: https://github.com/liquibase/liquibase-mongodb/blob/e1e4bfa3865f7125c1c54e748990d88129b83fbd/src/main/java/liquibase/ext/mongodb/lockservice/ReplaceLockChangeLogStatement.java#L80 I'm not sure I understand how exactly that should work. I might recommend adding...

I did some digging and was hoping to submit a PR to fix it however I have given up. Here is what I found: `ScalaTestAction.groovy` doesn't pass the W option...