openage icon indicating copy to clipboard operation
openage copied to clipboard

Minimap

Open sandsmark opened this issue 8 years ago • 4 comments

just rebased #559, + added support for using the mouse to move around from the minimap.

sandsmark avatar Oct 08 '17 08:10 sandsmark

fixed that.

but there seems to be more threading fuckery, I get a consistent crash on exit because of unbalanced access to the dbus library. I think it is related to the hacks with how qguiapplication is instantiated and executed, it has a ton of internal entry/atexit() handlers and whatnot, from plugins and all the modules, so e. g. trying to run exit() while it is alive is going to crash. why isn't it just executed as normal in main()?

   process 31792: arguments to dbus_connection_unref() were incorrect, assertion "connection->generation == _dbus_current_generation" failed in file dbus-connection.c line 2824.
This is normally a bug in some application using the D-Bus library.

sandsmark avatar Nov 12 '17 12:11 sandsmark

process 31792: arguments to dbus_connection_unref() were incorrect, assertion "connection->generation == _dbus_current_generation" failed in file dbus-connection.c line 2824. This is normally a bug in some application using the D-Bus library.

That's something SDL2-related. I remember deleting all of the Qt code and running the game - same error happens.

hacks with how qguiapplication is instantiated and executed ... why isn't it just executed as normal in main()?

That simplifies the "deleting all of the Qt code" part while testing.

There are requests to run headless, so Qt isn't needed in that configuration. The main() doesn't need to directly pass anything to qguiapplication even when there is a GUI. So we can try to avoid cluttering main() if possible.

VelorumS avatar Nov 13 '17 12:11 VelorumS

I'm too dumb for the coordinate magic, so if anyone wants to pick up this and fix it, feel free

sandsmark avatar Feb 25 '18 11:02 sandsmark

Oh no! The new coord system should be pretty straight-forward with the same ideas as the old one but with a much cleaner implementation. Would it help you if you came by in our chatroom so I/@mic-e answer your questions? What also might be useful is this document.

TheJJ avatar Feb 25 '18 21:02 TheJJ