ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

[Menu][MenuItem]: MenuItem font size has changed in ui5-webcomponents 1.24.11

Open shubhamnazare opened this issue 1 year ago • 2 comments

Bug Description

After upgrading ui5-webcomponents to 1.24.11 and ui5-webcomponents-react to 1.29.11, the font size in menu looks larger.

before upgrade example: https://stackblitz.com/edit/vitejs-vite-jxd18i?file=src%2FApp.jsx,package.json after upgrade example: https://stackblitz.com/edit/vitejs-vite-sscnqt?file=src%2FApp.jsx,package.json

Affected Component

Menu, MenuItem

Expected Behaviour

The font size should have been the same as before in ui5-webcomponents 1.23.3.

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.24.11

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • [X] I’m not disclosing any internal or sensitive information.

shubhamnazare avatar Oct 07 '24 10:10 shubhamnazare

Hi @SAP/ui5-webcomponents-topic-b ,

It seems that a font-size CSS property is missing in the ui5-menu-items.

A possible solution would be, to add font-size: var(--sapFontSize); to the text in the MenuListItem.css;

Best Regards, Stoyan

hinzzx avatar Oct 08 '24 12:10 hinzzx

Hi @hinzzx could you please let me know the ETA on this and in which patch the fix will be available?

shubhamnazare avatar Oct 15 '24 15:10 shubhamnazare

Hi @hinzzx Please let us know when this will be fixed as this is now high priority for us.

shubhamnazare avatar Oct 25 '24 07:10 shubhamnazare

Hi @shubhamnazare ,

The bug is fixed and will be available to be consumed the next week.

Best Regards, Stoyan

hinzzx avatar Oct 25 '24 12:10 hinzzx

:tada: This issue has been resolved in version v1.24.12 :tada:

The release is available on v1.24.12

Your semantic-release bot :package::rocket:

ui5-webcomponents-bot avatar Oct 29 '24 15:10 ui5-webcomponents-bot