ui5-webcomponents icon indicating copy to clipboard operation
ui5-webcomponents copied to clipboard

feat(ui5-flexible-column-layout): public layoutsConfiguration property

Open kineticjs opened this issue 1 year ago • 1 comments

Add public layoutsConfiguration property to allow the app customize the column proportions per screen size and layout. Also, update the layoutsConfiguration fields whenever the user interactively changes the column proportions by dragging the columns separator.

kineticjs avatar Jun 24 '24 11:06 kineticjs

As synced offline, the layoutsConfiguration is now a public property that is being changed by the component upon user interaction, it would help to fire an event and notify the application about those changes.

dobrinyonkov avatar Jun 28 '24 11:06 dobrinyonkov

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Sep 09 '25 13:09 cla-assistant[bot]

Can we discuss which name for the new event is better:

  1. layout-configuration-change
  2. layouts-configuration-change In this PR i named it layout-configuration-change, in analogy to the existing layout-change event. Also, the event fires when the user resizes the column of the current layout he is viewing i.e. upon config change of a single layout. However, given that the corresponding public property is layoutsConfiguration (with "s") would the second option be more consistent?

kineticjs avatar Oct 24 '25 12:10 kineticjs

Can we discuss which name for the new event is better:

  1. layout-configuration-change
  2. layouts-configuration-change In this PR i named it layout-configuration-change, in analogy to the existing layout-change event. However, given that the corresponding public property is layoutsConfiguration (with "s") would the second option be more consistent?

Honestly, I don't have a strong preference for either. Maybe, layout-configuration-change makes more sense semantically as the event detail only includes the layout that chaged. So I personally prefer layout-configuration-change but still choose whichever you prefer.

dobrinyonkov avatar Oct 27 '25 09:10 dobrinyonkov

Can we discuss which name for the new event is better:

  1. layout-configuration-change
  2. layouts-configuration-change In this PR i named it layout-configuration-change, in analogy to the existing layout-change event. However, given that the corresponding public property is layoutsConfiguration (with "s") would the second option be more consistent?

Honestly, I don't have a strong preference for either. Maybe, layout-configuration-change makes more sense semantically as the event detail only includes the layout that changed. So I personally prefer layout-configuration-change but still choose whichever you prefer.

OK, the current version seems better indeed. Let us keep it this way then.

kineticjs avatar Oct 27 '25 09:10 kineticjs

:tada: This PR is included in version v2.16.0-rc.3 :tada:

The release is available on v2.16.0-rc.3

Your semantic-release bot :package::rocket:

ui5-webcomponents-bot avatar Oct 30 '25 08:10 ui5-webcomponents-bot