SAP
feat(ui5-shellbar-branding): introduce new component
The branding slot has been introduced to the ui5-shellbar component.
Additionally, a new component called ui5-shellbar-branding has been added. This component combines a logo and a title, with the ability to open links. Its primary purpose is to be used within the branding slot, replacing the default primary title and logo of the ui5-shellbar.
The branding slot and its content take higher priority. As a result, if both the branding and the primary title + logo slot are used, only the ui5-shellbar-branding will be displayed.
Already looks good, just a few stuff to talk about:
- dedicated ShellBarBranding.cy.tsx file for the branding related tests?
- also, more tests for the ShellBarBranding logic like properties, acc, slots, ect?
- update all samples where shellbar is used with the new slot?
I know we talked to have the "primaryTitle/brandingTitle" as a slot, but now I'm rethinking, what if someone wants to have custom title later on, perhaps it could be better to "reserve" the slot for that and use a property now. We can have a call about this and decide.
FYI, we decided to go with the "branding" name, so ui5-shellbar-branding and branding slot are OK.
Check the playground to add a new docs page for the shellbar branding component.
You can also add the exp and new tags to be displayed in the playground's component tree.
Consider using a PR title that reflects the creation of a new component, such as:
feat(ui5-shellbar-branding): introduce new component
:tada: This PR is included in version v2.12.0 :tada:
The release is available on v2.12.0
Your semantic-release bot :package::rocket:
