ui5-typescript icon indicating copy to clipboard operation
ui5-typescript copied to clipboard

`sap.ushell.Container` removed in 1.100?

Open DetachHead opened this issue 3 years ago • 4 comments

the sap.ushell.Container const that was defined in sap.ushell.d.ts seems to no longer be present in version 1.100. how come it was removed?

DetachHead avatar Mar 24 '22 01:03 DetachHead

@aschmalzhaf can you please take a look and comment? Did only the global name disappear and it's possible now to access sap.ushell.Container via a module export in UI5 1.100?

codeworrior avatar Mar 24 '22 09:03 codeworrior

The issue should be fixed with newer UI5 versions (1.102++ should work fine). Please excuse all inconveniences.

aschmalzhaf avatar May 30 '22 14:05 aschmalzhaf

Hold on... I don't think so.

It appears as a class at https://ui5.sap.com/1.101.0/#/api/sap.ushell.Container, but loaded from module "sap/ushell/Container". In 1.99 it used to be a field on the namespace (https://ui5.sap.com/1.99.0/#/api/sap.ushell), which it isn't anymore.

So it's sort of back again after disappearing in 1.100, but not like it used to be. A question to @DetachHead would be whether it would be acceptable to import it from module "sap/ushell/Container" instead of addressing it as a global - and whether this works at all, giving access to the singleton instance.

Edit: a quick test seems to show that the class is imported, not the singleton instance.

akudev avatar May 30 '22 15:05 akudev

Now internally tracked as 2280149651 to get it handled.

akudev avatar Aug 01 '22 16:08 akudev