ui5-typescript
ui5-typescript copied to clipboard
ts-types-esm: Core.getLibraryResourceBundle missing overrides
In Core.getLibraryResourceBundle you now define
getLibraryResourceBundle = function(sLibraryName, sLocale, bAsync)
While looking at the code you actually should have three overrides
getLibraryResourceBundle = function(sLibraryName, sLocale, bAsync)
getLibraryResourceBundle = function(sLibraryName, bAsync)
getLibraryResourceBundle = function(bAsync)
The return Promise is also of type any when it should be Promise<ResourceBundle>
by the way it can be even cooler if you were to do all variant properly
getLibraryResourceBundle(sLibraryName: string, bAsync: true): Promise<ResourceBundle>;
getLibraryResourceBundle(sLibraryName: string, bAsync: false): ResourceBundle;
getLibraryResourceBundle(sLibraryName: string): ResourceBundle;
...
We're currently working on the missing overrides for signatures like the one of getLibraryResourceBundle.
But we won't manage to do the"cooler" thing yet, documentation doesn't provide enough information to extract the 'real' variants.
Having already the proper override would be good :)