ui5-tooling
ui5-tooling copied to clipboard
Add additional checks to CI tests
The Travis builds in all repos should also check for:
- [ ] 1. Commit message style
- Especially correct prefixes (e.g.
[INTERNAL] ModuleName: Bla bla bla)
- Especially correct prefixes (e.g.
- [x] 2. ~Odd package-lock.json changes~ - obsolete
- See https://github.com/SAP/ui5-builder/pull/49#issuecomment-402734159
- [ ] 3. SAP internal URLs
- [ ] 4. Size of
node_modules- Compare size of
node_modulesinstallation of a single module before and after a change
- Compare size of
- [x] 5. Check for unused dependencies
- Consider use of depcheck
- [ ] 6. Compare CLI runtime before and after a change
- Consider use of hyperfine
- [ ] 7. Check for new vulnerabilities in dependencies
- Consider use of audit-ci
- Also: WhiteSource
I think 2. is rather related to npm and different versions. To me this change looks correct and it might have been just wrong before. Therefore, we should maybe also describe the expected environment for development (at least the major Node.js / npm version).
@ecker fyi bullet no. 7