ui5-tooling icon indicating copy to clipboard operation
ui5-tooling copied to clipboard

Add additional checks to CI tests

Open RandomByte opened this issue 7 years ago • 2 comments

The Travis builds in all repos should also check for:

  • [ ] 1. Commit message style
    • Especially correct prefixes (e.g. [INTERNAL] ModuleName: Bla bla bla)
  • [x] 2. ~Odd package-lock.json changes~ - obsolete
    • See https://github.com/SAP/ui5-builder/pull/49#issuecomment-402734159
  • [ ] 3. SAP internal URLs
  • [ ] 4. Size of node_modules
    • Compare size of node_modules installation of a single module before and after a change
  • [x] 5. Check for unused dependencies
  • [ ] 6. Compare CLI runtime before and after a change
  • [ ] 7. Check for new vulnerabilities in dependencies
    • Consider use of audit-ci
    • Also: WhiteSource

RandomByte avatar Jul 05 '18 15:07 RandomByte

I think 2. is rather related to npm and different versions. To me this change looks correct and it might have been just wrong before. Therefore, we should maybe also describe the expected environment for development (at least the major Node.js / npm version).

matz3 avatar Jul 06 '18 07:07 matz3

@ecker fyi bullet no. 7

RandomByte avatar Apr 04 '19 14:04 RandomByte