styleguides icon indicating copy to clipboard operation
styleguides copied to clipboard

Published 20 hours ago • verified publisher icon SAP

Comment>Manual versioning

Open AlexandreHT opened this issue 3 years ago • 2 comments
trafficstars

Hi, Manual versioning with code comment is (was?) a widespread practice in the ABAP world whereas it's flagged as bad practice in Clean Code (Chap.4 "Attribution and byline").

I don't think it's controversial here so I've directly created a PR.

AlexandreHT avatar Jun 08 '22 16:06 AlexandreHT

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Jun 08 '22 16:06 cla-assistant[bot]

We'll rework the formulation and then merge this.

HrFlorianHoffmann avatar Jul 18 '22 13:07 HrFlorianHoffmann

Hi @SAP/clean-abap-code-owner, please vote on the PR! Based on the voting and if there is no veto we merge it latest in two weeks from now. Thanks and Regards, Klaus

KlausHaeuptleSAP avatar Aug 22 '22 14:08 KlausHaeuptleSAP