project-portal-for-innersource icon indicating copy to clipboard operation
project-portal-for-innersource copied to clipboard

Published 20 hours ago • verified publisher icon SAP

Remove tracked dependencies

Open dellagustin opened this issue 4 years ago • 3 comments

Dependencies were being tracked despite the .gitignore and the postinstall script.

With this PR, the tracked dependencies are removed. The .gitignore rules were updated to ignore everything in the lib folder except for the README.md file.

dellagustin avatar Jul 08 '21 20:07 dellagustin

Great find!

Do you have any suspicions why the .gitignore file didn't work as expected? Just curious.

spier avatar Jul 09 '21 05:07 spier

Hi @spier, I suspect that the .gitignore rule was added after the files were already tracked (that could be verified on the history, but I did not went that far).

dellagustin avatar Jul 10 '21 07:07 dellagustin

Hi @dellagustin, these files are checked in intentionally as we do not have a build step for gh_pages currently. While they are not needed for a local setup (postinstall step is taking care of it) this would break the online demo. It could be achieved by setting up a travis job however.

Michadelic avatar Jul 14 '21 09:07 Michadelic