openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard

Enhancement Request: Please support for both ODataModel getProperty and v2.ODataModel getProperty for 1..n/0..n navigation properties

Open DerGuteWolf opened this issue 10 years ago • 4 comments

Please support for both ODataModel getProperty and v2.ODataModel getProperty for 1..n/0..n navigation properties!

This is a followup to https://github.com/SAP/openui5/issues/676

DerGuteWolf avatar Nov 12 '15 13:11 DerGuteWolf

Hi, thanks for your message, I'll let the responsible colleagues know! Kind regards, Christiane

christianegoebels avatar Nov 13 '15 09:11 christianegoebels

Hi Wolf,

what result would you expect, when calling getProperty on a navigation property? Unfortunately changing the current behaviour will be incompatible to applications already using getProperty on navigation properties, but maybe we can introduce new methods for that purpose?

Regards, Malte

goligo avatar Nov 13 '15 09:11 goligo

Well, either leave the current implementation (returning a list of Strings containing "entityset(primary key)" entries) and document it as requsted in #676 or return a list of objects similar to what returned with bIncludeExpandEntries=true .

DerGuteWolf avatar Nov 13 '15 10:11 DerGuteWolf

Given ASet?$filter=xyz&$expand=BSet and the result containing ASet(1), I would expected getProperty('ASet(1)', true).BSet to be equal to getProperty('ASet(1)/BSet') which is not the case currently.

DerGuteWolf avatar Nov 13 '15 17:11 DerGuteWolf

Hi @DerGuteWolf ,

this requirement has been around for some years. However, it seems that commit https://github.com/SAP/openui5/commit/c76bd307900214194599c43f43b26b81539efa38 from June 2016 already addressed this issue. The method https://ui5.sap.com/#/api/sap.ui.model.odata.v2.ODataModel%23methods/getObject had been introduced with the change. Accessing navigation properties through https://ui5.sap.com/#/api/sap.ui.model.odata.v2.ODataModel%23methods/getProperty was deprecated at the same time.

I am hence closing the issue.

Best regards Mathias.

uhlmannm avatar Sep 01 '22 10:09 uhlmannm